Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not working on components #14

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Fix not working on components #14

merged 3 commits into from
Jan 18, 2022

Conversation

cacalo
Copy link
Contributor

@cacalo cacalo commented Jan 15, 2022

There were 2 different issues i fixed with this update:

  • 'id' needed to be updated to '$id' in schemas, to comply with current standards. This fixes working in Angular 13 projects.
  • Component specs creation now needs new data "type". This information was already on the workflow but was not sent to the preset applier.

Package currently working in Angular 13.1.2

@smnbbrv smnbbrv merged commit 0bacb19 into smnbbrv:master Jan 18, 2022
@smnbbrv
Copy link
Owner

smnbbrv commented Jan 18, 2022

Hi, thanks for the pull request! The new version is released, please validate

@cacalo
Copy link
Contributor Author

cacalo commented Jan 18, 2022

It looks like everything is working :)

@cacalo cacalo deleted the Fix_Not_working_on_components branch January 19, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cacalo @smnbbrv