fix #167 (#168)

CHANGES.txt

@@ -1,6 +1,10 @@
 Changes
 =======
 
+0.10.1 (2024-02-19)
+------------------
+- check that table to be refreshed exists when using bc2pg --refresh (#167)
+
 0.10.0 (2024-02-19)
 ------------------
 - store known primary keys in repository (data/primary_keys.json)

bcdata/__init__.py

@@ -15,4 +15,4 @@
     "https://raw.githubusercontent.com/smnorris/bcdata/main/data/primary_keys.json"
 )
 
-__version__ = "0.10.1dev0"
+__version__ = "0.10.1"

bcdata/cli.py

@@ -395,9 +395,16 @@ def bc2pg(
     elif refresh and schema:
         schema_target = schema
     elif refresh and not schema:
-        schema_target, t = bcdata.validate_name(dataset).lower().split(".")
+        schema_target, table = bcdata.validate_name(dataset).lower().split(".")
     if refresh:
+        db = Database(db_url)
         schema = "bcdata"
+        if not table:
+            table = bcdata.validate_name(dataset).lower().split(".")
+        if schema_target + "." + table not in db.tables:
+            raise ValueError(
+                f"Cannot refresh, {schema_target}.{table} not found in database"
+            )
     out_table = bcdata.bc2pg(
         dataset,
         db_url,

bcdata/database.py

@@ -120,6 +120,10 @@ def refresh(self, schema, table):
             )
             self.execute(dbq)
             self.drop_table("bcdata", table)
+        else:
+            raise ValueError(
+                f"Target table {schema}.{table} does not exist in database"
+            )
 
     def define_table(
         self,

tests/test_cli.py

@@ -112,3 +112,20 @@ def test_bc2pg_refresh():
     assert AIRPORTS_TABLE.lower() in DB_CONNECTION.tables
     assert len(q) == 1
     DB_CONNECTION.execute("drop table " + AIRPORTS_TABLE.lower())
+
+
+def test_bc2pg_refresh_fails_table_does_not_exist():
+    runner = CliRunner()
+    result = runner.invoke(
+        cli,
+        [
+            "bc2pg",
+            AIRPORTS_TABLE,
+            "--db_url",
+            DB_URL,
+            "--count",
+            "1",
+            "--refresh",
+        ],
+    )
+    assert result.exit_code == 1