Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate, Cleaned up EV and IV exporting #435

Merged
merged 10 commits into from Apr 27, 2021
Merged

Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate, Cleaned up EV and IV exporting #435

merged 10 commits into from Apr 27, 2021

Conversation

jbmagier
Copy link
Contributor

No description provided.

@jbmagier
Copy link
Contributor Author

The test failures don't appear to be related to any code I've written, but rather the bundle file which I made no changes to.

@jbmagier jbmagier changed the title Added Power Spot Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate Mar 28, 2021
@jbmagier jbmagier changed the title Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate, Cleaned up EV and IV exporting Mar 28, 2021
@DaWoblefet
Copy link
Member

Power Spot is 0x14CD (5325), same as Battery.

@jbmagier
Copy link
Contributor Author

Power Spot is 0x14CD (5325), same as Battery.

0x14CD was used in gen78, but 0x14CC was used in gen56 to match battery (neither of which exist in gen 5 and 6).

@DaWoblefet
Copy link
Member

Power Spot is 0x14CD (5325), same as Battery.

0x14CD was used in gen78, but 0x14CC was used in gen56 to match battery (neither of which exist in gen 5 and 6).

Makes sense to me. Shouldn't there just be no logic in the Gen 56 mechanics file then? There's no reason to include it for generations where it doesn't exist (maybe it crashes or something without it? idk)

(Kris asked me to review for accuracy, verifying this looks good mechanics-wise to me)

@jbmagier
Copy link
Contributor Author

Before this is all implemented, the issue of the description of max weather ball (etc) being the right max move should be fixed.

@KrisXV
Copy link
Member

KrisXV commented Apr 23, 2021

Before this is all implemented, the issue of the description of max weather ball (etc) being the right max move should be fixed.

Are you offering to fix it or just stating that it should be fixed?

@jbmagier
Copy link
Contributor Author

Before this is all implemented, the issue of the description of max weather ball (etc) being the right max move should be fixed.

Are you offering to fix it or just stating that it should be fixed?

Stating. Last time I looked at the code I couldn't crack how to achieve that.

@jbmagier
Copy link
Contributor Author

Before this is all implemented, the issue of the description of max weather ball (etc) being the right max move should be fixed.

Are you offering to fix it or just stating that it should be fixed?

Stating. Last time I looked at the code I couldn't crack how to achieve that.

If I recall correctly, the function getMaxMoveName needs access to field which I wasn't able to figure out given my lack of knowledge in ts.

@DaWoblefet DaWoblefet mentioned this pull request Apr 25, 2021
Open
@KrisXV
Copy link
Member

KrisXV commented Apr 27, 2021

Before this is all implemented, the issue of the description of max weather ball (etc) being the right max move should be fixed.

Are you offering to fix it or just stating that it should be fixed?

Stating. Last time I looked at the code I couldn't crack how to achieve that.

If I recall correctly, the function getMaxMoveName needs access to field which I wasn't able to figure out given my lack of knowledge in ts.

I'll tackle this later but merge for now.

@KrisXV KrisXV merged commit 8d527cb into smogon:master Apr 27, 2021
GriffinLedingham added a commit to pikalytics/damage-calc that referenced this pull request Jun 7, 2021
@GriffinLedingham
Merge branch 'smogon-master'
6ecef23 
* smogon-master:
  Update copyright year
  Update dependencies
  Gen 7/8: Fix -ate abilities, Reckless, and Iron Fist (smogon#446)
  Convert modifiers from hex to decimal (smogon#444)
  Fix broken link in README.md (smogon#431)
  Function modularization tweaks (gens 7, 8) and iron ball calculations (smogon#439)
  Fix Reversal and Flail power calculation for Gen 4 (smogon#433)
  Actually fix build
  Fix build
  Gen 3: Double Facade base power when poisoned, paralyzed or burned (smogon#412)
  Added Power Spot, Fixed Dauntless Shield, Made Competitive activate from Intimidate, Cleaned up EV and IV exporting (smogon#435)
  Fix Rivalry boost (smogon#440)
  Change BP limit from 999 to 65535 (smogon#442)
  Update packages and fix build
  Search for imported sets (smogon#428)
  Docker addition api (smogon#422)
  Modularize the Gen 7 & 8 mechanics page (smogon#429)
  New TextField for naming the imported sets (smogon#423)
  Export import bugfix (smogon#426)
  Support field-wide Fairy Aura, Dark Aura and Aura Break when neither Pokemon uses the ability (smogon#430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbmagier @DaWoblefet @KrisXV