Improve Weight Handling #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
* Float Stone now stacks with Light Metal and Heavy Metal * getWeightFactor now populates the description item/ability as applicable
* renamed getWeightFactor to getWeight
* This matches the Showdown! implementation of the same: https://github.com/smogon/pokemon-showdown/blob/945b9962b8a287c9b4abebe89313f17437cff111/data/abilities.ts#L2097
Ability and Item weight modifiers are now handled completely independently of each other
|
Rebased to fix the merge conflict. It was a trivial import conflict. |
thejetou
reviewed
Mar 5, 2024
|
Great work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added tests for weight handling that mirror Showdown's.
This should address the weight-based inaccuracies expressed in #443