Honkalculate no longer covers tiers #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejetou
reviewed
May 10, 2024
| @@ -886,7 +887,7 @@ | |||
| </fieldset> | |||
| </div> | |||
| <div> | |||
| <fieldset class="panel holder-0"> | |||
| <fieldset class="panel" id="holder-0"> | |||
There was a problem hiding this comment.
holder-0 doesn't exist anymore though. You said you switched it into an ID but it seems like you just removed it.
There was a problem hiding this comment.
I change the code in honkalculate_controls.js to accomodate the fact that it is an ID instead of a class.
I did delete the CSS code that was associated with holder-0 since I had commented out all of that CSS code and it wasn't necessary anymore.
There was a problem hiding this comment.
Ah, I see. Thanks for explaining.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/pok%C3%A9mon-showdown-damage-calculator.3593546/post-10085323
The Honkalculate table no longer uses
position: absoluteto position itself on the page, so it (shouldn't) cover the list of tiers that you are pulling sets from.As an aside (outside the scope of this PR), the Honkalculator is kinda jank and I also dislike how the UI looks and behaves.