Teambuilder/Battle/Sprite support for mods #1697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took the "Batteries not included" version of pokemon-showdown-client from the main repo and copied in the changed files from my custom client for Dragon Heaven (Smogon Pet Mods basically)
Missing Space edition
forgot to save the file edition
Not sure about this one, it seems to be asking for semicolons in nonsensical places and finding trailing spaces where there are none. Am I in the wrong file?
AnnikaCodes
reviewed
Dec 20, 2020
Co-authored-by: Annika <annika0uwu@gmail.com>
AnnikaCodes
requested changes
Dec 20, 2020
There was a problem hiding this comment.
I recommend that you read over the contributing and style guide.
Co-authored-by: Annika <annika0uwu@gmail.com>
Co-authored-by: Annika <annika0uwu@gmail.com>
Co-authored-by: Annika <annika0uwu@gmail.com>
Co-authored-by: Annika <annika0uwu@gmail.com>
Co-authored-by: Annika <annika0uwu@gmail.com>
Co-authored-by: Annika <annika0uwu@gmail.com>
…showdown-client" This reverts commit dfaa02b, reversing changes made to aec5deb.
|
This (or a version very similar to it) has been used and tested for many weeks here: https://dragonheaven.herokuapp.com/ This now has:
Please let me know if you need me to refactor anything. I have generally minimized the size of teambuilder-tables (it's about twice as big with 20 mods as it is with 0), as mentioned before, and moved some data into other build tables with more appropriate names. I'm willing to do a lot if you'll point me in the right direction, but I also understand if this is too much to change with Zarel's current overhaul of the client. |
testing after I made changes for typescript errors showed a new issue, so i fixed that
mods now load directly from the mod folder
the occasional optional config data is now specified in scripts.ts in the mod folder rather than in a statement at the top of build-indexes
but I'm not sure if that's where they should be stored
loading past gens as mods changes the tiersets of some of the past gen formats and is totally unneccessary, so I think it's best to just exclude them
scoopapa
changed the title
Shortens and simplifies the code in multiple places, and makes it easier to add/retrieve new types of data from the build tables. Also made a change that marginally decreased the size of teambuilder-tables
Zarel
force-pushed
the
master
branch
2 times, most recently
from
f5d3242
to
c24cbd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This is now mostly ready to go. I'm still willing to refactor anything that needs it. There is one issue that I wanted to ask a dev about: where should custom sprites go? Right now it looks for sprites on the server at data/mods/[modName]/sprites but I want to double check before I finalize that aspect.