Make hyperlinks more visible when displayed in /wall #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zarel
reviewed
Dec 8, 2021
style/client.css
Outdated
| @@ -1355,6 +1355,9 @@ p.or:after { | |||
| padding: 0 4px 0 3px; | |||
| font-style: normal; | |||
| } | |||
| .chat span a small { | |||
There was a problem hiding this comment.
span is probably not the correct match. Doesn't /wall have a class on that span?
There was a problem hiding this comment.
This should probably be next to the thing that makes the regular link text gray, too.
There was a problem hiding this comment.
Ah, I see, it's right below this. This should be moved below .chat small, rather than above. Also, the selector should be .chat .message-announce small.
There was a problem hiding this comment.
Hm, the contrast here is kind of poor. Probably the background on announcements should be darker.
There was a problem hiding this comment.
Should I make the background color of .message-announce from battle-log.css darker ?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's a small workaround regarding this : https://www.smogon.com/forums/threads/make-hyperlinks-more-visible-when-having-them-displayed-in-wall-or-announce.3693900/
(excuse the large amount of commits, I made a mess with my branches)