Add favorite format feature #1927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mia-pi-git
reviewed
Jan 23, 2022
js/client-chat.js
Outdated
| this.add('That format does not exist.'); | ||
| return false; | ||
| } | ||
| if (!localStorage.getItem('favoriteFormats')) { |
There was a problem hiding this comment.
Use Storage.prefs('favoriteformat') instead of localStorage.getItem.
mia-pi-git
reviewed
Jan 23, 2022
mia-pi-git
reviewed
Jan 23, 2022
mia-pi-git
reviewed
Jan 23, 2022
mia-pi-git
reviewed
Jan 23, 2022
Co-authored-by: Mia <49593536+mia-pi-git@users.noreply.github.com>
|
|
mia-pi-git
reviewed
Jan 27, 2022
mia-pi-git
reviewed
Jan 27, 2022
| } | ||
| buf += '<button class="button" name="parseCommand" value="/favoriteformat list">(Back to List)</button>'; | ||
| buf += '</div>'; | ||
| this.add('|uhtmlchange|favformat|' + buf); |
There was a problem hiding this comment.
Suggested change
| this.add('|uhtmlchange|favformat|' + buf); | |
| this.add('|uhtmlchange|favformat|' + buf); |
Probably would be easier to use popups - otherwise, how does the UHTML work when they aren't in a room?
There was a problem hiding this comment.
Hmm, yeah, popups do sound better
mia-pi-git
reviewed
Jan 27, 2022
KrisXV
reviewed
Jan 27, 2022
Co-authored-by: Mia <49593536+mia-pi-git@users.noreply.github.com> Co-authored-by: Kris Johnson <11083252+KrisXV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion taken from here