Pet Mod Support (Alternatium [PMOTS]) #1936
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial teambuilder support for PMOTS/Leader's Choice (not showing, yet)
Add everything except for support for custom Pokemon for Alternatium
KrisXV
requested changes
Feb 5, 2022
build-tools/build-indexes
Outdated
|
|
||
| // process.stdout.write("\n "); | ||
| for (const genIdent of [...GENS, ...DOUBLES, ...VGC, ...NFE, ...STADIUM, ...OTHER]) { | ||
| const isLetsGo = (genIdent === 7.1); | ||
| const isBDSP = (genIdent === 8.6 || genIdent === -8.6); | ||
| const isPMOTS = (genIdent === 8.7); | ||
| const isLC = (genIdent === 8.8); |
There was a problem hiding this comment.
LC means little cup in most context, use isPetModLC here please
build-tools/build-indexes
Outdated
Comment on lines
548
to
563
| } else if (isPMOTS) { | ||
| BattleTeambuilderTable['alternatium'] = {}; | ||
| BattleTeambuilderTable['alternatium'].learnsets = {}; | ||
| BattleTeambuilderTable['alternatium'].tiers = tiers; | ||
| BattleTeambuilderTable['alternatium'].items = items; | ||
| BattleTeambuilderTable['alternatium'].overrideTier = overrideTier; | ||
| BattleTeambuilderTable['alternatium'].monotypeBans = monotypeBans; | ||
| BattleTeambuilderTable['alternatium'].formatSlices = formatSlices; | ||
| } else if (isLC) { | ||
| BattleTeambuilderTable['randomdex'] = {}; | ||
| BattleTeambuilderTable['randomdex'].learnsets = {}; | ||
| BattleTeambuilderTable['randomdex'].tiers = tiers; | ||
| BattleTeambuilderTable['randomdex'].items = items; | ||
| BattleTeambuilderTable['randomdex'].overrideTier = overrideTier; | ||
| BattleTeambuilderTable['randomdex'].monotypeBans = monotypeBans; | ||
| BattleTeambuilderTable['randomdex'].formatSlices = formatSlices; |
There was a problem hiding this comment.
why not make these tables just say 'pmots' and 'petmodlc'
build-tools/build-indexes
Outdated
Comment on lines
603
to
605
| if (isPMOTS) { | ||
| return ["OU"]; | ||
| } |
There was a problem hiding this comment.
this isnt necessary, it uses the default gen 8 table (which includes OU)
There was a problem hiding this comment.
In Alternatium's case, it only contains OU mons, so this is necessary.
There was a problem hiding this comment.
No it’s not, look at how nfe does it
build-tools/build-indexes
Outdated
Comment on lines
909
to
972
| const BDSPLearnsets = Dex.mod('gen8bdsp').data.Learnsets; | ||
| for (const id in BDSPLearnsets) { | ||
| const species = Dex.mod('gen8bdsp').species.get(id); | ||
| if (species.isNonstandard && !['Unobtainable', 'CAP'].includes(species.isNonstandard)) continue; | ||
| const learnset = BDSPLearnsets[id].learnset; | ||
| BattleTeambuilderTable['gen8bdsp'].learnsets[id] = {}; | ||
| const PMOTSLearnsets = Dex.mod('alternatium').data.Learnsets; | ||
| for (const id in PMOTSLearnsets) { | ||
| const species = Dex.mod('alternatium').species.get(id); | ||
| const learnset = PMOTSLearnsets[id].learnset; | ||
| BattleTeambuilderTable['alternatium'].learnsets[id] = {}; | ||
| for (const moveid in learnset) { | ||
| BattleTeambuilderTable['alternatium'].learnsets[id][moveid] = '8'; | ||
| } | ||
| } | ||
| const LCLearnsets = Dex.mod('randomdex').data.Learnsets; | ||
| for (const id in LCLearnsets) { | ||
| const species = Dex.mod('randomdex').species.get(id); | ||
| const learnset = LCLearnsets[id].learnset; | ||
| BattleTeambuilderTable['randomdex'].learnsets[id] = {}; | ||
| for (const moveid in learnset) { | ||
| BattleTeambuilderTable['gen8bdsp'].learnsets[id][moveid] = '8g'; | ||
| BattleTeambuilderTable['randomdex'].learnsets[id][moveid] = '8'; |
There was a problem hiding this comment.
._. why are you removing bdsp support
| @@ -1046,7 +1102,7 @@ process.stdout.write("Building `data/teambuilder-tables.js`... "); | |||
| // Mods | |||
| // | |||
|
|
|||
| for (const mod of ['gen7letsgo', 'gen8bdsp']) { | |||
| for (const mod of ['gen7letsgo', 'gen8bdsp', 'alternatium', 'randomdex']) { | |||
There was a problem hiding this comment.
this is more server-side, but we should probably make these mod files pmots and pmlc to make support consistent in future cases
build-tools/build-indexes
Outdated
| @@ -1057,13 +1113,41 @@ process.stdout.write("Building `data/teambuilder-tables.js`... "); | |||
| for (const id in modData.Pokedex) { | |||
| const modEntry = modData.Pokedex[id]; | |||
| const parentEntry = parentData.Pokedex[id]; | |||
| if (typeof parentEntry === 'undefined') { | |||
There was a problem hiding this comment.
Suggested change
| if (typeof parentEntry === 'undefined') { | |
| if (!parentEntry) { |
Added back BDSP support for learnsets (sorry!) and changed things up to be more in line with general PMOTS/Leader's Choice support. Also changed isLC to isPetModLC for clarification.
|
I'd like to point out that the custom Pokemon added by Alternatium show up if you search for them in other formats. BDSP: National Dex: I am not sure how to disable this. |
Make PMOTS only show OU mons, while making all other mons illegal.
|
Alternatium isn't a pet mod playable on the server any more so I am going to mark this as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried my best coding teambuilder support for Alternatium, and to make a template for future PMOTS/Leader's Choice Pet Mods to follow. There's only two things that are missing right now:
Let me know if you have any suggestions!