Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sheer Force and Shield Dust mechanics #3339

Closed
Marty-D opened this issue Mar 6, 2017 · 3 comments
Closed

New Sheer Force and Shield Dust mechanics #3339

Marty-D opened this issue Mar 6, 2017 · 3 comments

Comments

@Marty-D
Copy link
Collaborator

Marty-D commented Mar 6, 2017

  • Sheer Force boosts Anchor Shot, Genesis Supernova, Sparkling Aria, Spirit Shackle, and Throat Chop and removes their effects despite not having a secondary effect/chance in their move data.

  • Shield Dust prevents Anchor Shot, Spirit Shackle, and Throat Chop's effects (but not the others mentioned above).

There are probably a number of ways to accomplish this so let's discuss the best ones.

@Marty-D Marty-D created this issue from a note in Gen 7 Release (To do) Mar 6, 2017
@ascriptmaster
Copy link
Contributor

ascriptmaster commented Mar 6, 2017

We could just throw them into the secondaries with 100% proc rate using the onHit handler like Tri Attack, and add some sort of flag for Sparkling Aria and Genesis Supernova so Shield Dust doesn't block it. Unless they have some sort of different priority such that Poison Touch always activates before/after it, guaranteed. Something like this:

secondary: {
    unblockable: true,
    chance: 100,
    onHit: function (target) {
        if (target.status === 'brn') target.cureStatus();
    }
}

@Zarel
Copy link
Member

Zarel commented Mar 6, 2017

Clarify "despite not having a secondary effect/chance in their move data"?

@Marty-D
Copy link
Collaborator Author

Marty-D commented Mar 6, 2017

@ascriptmaster Ah yes, I forgot Tri Attack already set a precedent for this kind of thing. Thanks, that sounds like the simplest option then. (Tempted to name the flag dustproof though!)

@Zarel I was referring to the game data for moves. Looking again, I guess Throat Chop might have a case, but partial-trapping moves are also categorized as "Damage + secondary effect" with 100% chances and those aren't affected by either Sheer Force or Shield Dust. I'm suspecting some hardcoding happened for these, and that's kind of strange since it couldn't have been done by accident. Why start deviating now?

@Marty-D Marty-D closed this as completed in c1036db Mar 6, 2017
azum4roll pushed a commit to azum4roll/Pokemon-Showdown that referenced this issue Mar 11, 2017
SaintCoke pushed a commit to SaintCoke/Pokemon-Showdown that referenced this issue May 1, 2017
@Marty-D Marty-D moved this from To do to Done in Gen 7 Release Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants