Fix Tera Shift not updating Terapagos's HP #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tera Shift does not update Terapagos to its correct HP stat on transforming. It should jump from 90 base HP as the base form to 95 HP as Terastal form. We have similar behavior in place for Stellar Terapagos and Zygarde-Complete.
This fix works, but I'm not sure why we have to do it in the first place. Wouldn't it be better to have the stat update happen in the formeChange function? We'd run into the same problem the next time another form change that modifies base HP happens.