Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gen 9 BSS Factory #10180

Merged
merged 12 commits into from
Jun 1, 2024
Merged

Add Gen 9 BSS Factory #10180

merged 12 commits into from
Jun 1, 2024

Conversation

LegoFigure11
Copy link
Contributor

This pull request adds Gen 9 BSS Factory.

Sets by @NO-VED and the rest of the BSS Factory team. Full credits can be found in the forum thread that will be made public once the format goes live.

Apologies if there are any formatting or code style issues, I couldn't get eslint to play nice on my machine. Passes all tests but if there are other issues please let me know and I'll try to amend them in the coming days!

Copy link
Contributor

@ACakeWearingAHat ACakeWearingAHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are a massive, massive amount of changes, but they're all for consistency, code standards, and clarity. Let me know when you're done looking and talking over these. Livid will review the code portion later.

data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
data/bss-factory-sets.json Outdated Show resolved Hide resolved
@LegoFigure11
Copy link
Contributor Author

Addressed all except the Roaring Moon set that I'm waiting to hear back on still

Sets were expanded/shrunk automatically by my linter based on line length, I've changed them all manually but it's gonna make maintaining this file a PITA. Is it really necessary? I would argue that it's more readable if they're all expanded anyway, but that's not my call to make.

Copy link
Contributor

@ACakeWearingAHat ACakeWearingAHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets are approved. Code review coming soon. Apologies for the wait.

data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
@LegoFigure11
Copy link
Contributor Author

Made all requested changes @livid-washed

data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@livid-washed livid-washed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. Approved.

@LegoFigure11
Copy link
Contributor Author

I do believe that's everything! Ready for merge, or further review if anyone else wants to take a look.

data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
data/random-teams.ts Outdated Show resolved Hide resolved
@DaWoblefet
Copy link
Member

Can you also update the /battlefactory help command to indicate support for the latest generation?

@LegoFigure11
Copy link
Contributor Author

Sure! I believe Mathy is working on updating the command.

@ACakeWearingAHat
Copy link
Contributor

(moving to spotlight section temporarily was approved by rands leadership)

LegoFigure11 and others added 4 commits May 31, 2024 14:19
@LegoFigure11
Copy link
Contributor Author

Sorry for review requests, I botched a rebase

@LegoFigure11 LegoFigure11 marked this pull request as ready for review May 31, 2024 04:28
@monsanto monsanto removed their request for review June 1, 2024 16:50
config/formats.ts Outdated Show resolved Hide resolved
@KrisXV KrisXV merged commit 1f3b2e4 into smogon:master Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants