-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gen 9 BSS Factory #10180
Add Gen 9 BSS Factory #10180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are a massive, massive amount of changes, but they're all for consistency, code standards, and clarity. Let me know when you're done looking and talking over these. Livid will review the code portion later.
Addressed all except the Roaring Moon set that I'm waiting to hear back on still Sets were expanded/shrunk automatically by my linter based on line length, I've changed them all manually but it's gonna make maintaining this file a PITA. Is it really necessary? I would argue that it's more readable if they're all expanded anyway, but that's not my call to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets are approved. Code review coming soon. Apologies for the wait.
Made all requested changes @livid-washed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me. Approved.
I do believe that's everything! Ready for merge, or further review if anyone else wants to take a look. |
Can you also update the /battlefactory help command to indicate support for the latest generation? |
Sure! I believe Mathy is working on updating the command. |
(moving to spotlight section temporarily was approved by rands leadership) |
Co-Authored-By: NO-VED <16705080+no-ved@users.noreply.github.com>
Apologies in advance to my linter
That's what I get for copy pasting
per ACakeWearingAHat
Sorry for review requests, I botched a rebase |
This pull request adds Gen 9 BSS Factory.
Sets by @NO-VED and the rest of the BSS Factory team. Full credits can be found in the forum thread that will be made public once the format goes live.
Apologies if there are any formatting or code style issues, I couldn't get eslint to play nice on my machine. Passes all tests but if there are other issues please let me know and I'll try to amend them in the coming days!