Add unlogtext command #2645

team1257Simon · 2016-07-26T04:29:30Z

The unlogtext command clears a banned user's messages from the room such that regular users can no longer see them (staff still can), which is useful if they leaked something sensitive/private. This was partially suggested in the issues file under "Fixes to text hiding." #2444

panpawn · 2016-07-27T01:33:42Z

commands.js

@@ -1891,7 +1891,28 @@ exports.commands = {
 		if (userid !== toId(this.inputUsername)) this.add('|unlink|' + hidetype + toId(this.inputUsername));
 	},
 	hidetexthelp: ["/hidetext [username] - Removes a locked or banned user's messages from chat (includes users banned from the room). Requires: % (global only), @ * # & ~"],
-


don't remove this empty line

panpawn · 2016-07-27T01:39:10Z

Did you test this command? Because it doesn't work...

panpawn · 2016-07-27T01:39:27Z

commands.js

+		}
+		if (!targetUser) return this.errorReply("User '" + name + "' not found.");
+		if (!(targetUser.locked || (room.bannedUsers[toId(name)] && room.bannedIps[targetUser.latestIp]) || user.can('rangeban'))) return this.errorReply("User '" + name + "' is not banned from this room or locked.");
+		let roomlog = room.log.split(",");


CRASH: TypeError: room.log.split is not a function

panpawn · 2016-07-27T01:43:27Z

If this command gets added, it definitely shouldn't be given to global drivers...

Also, it doesn't modlog that someone cleared someone's messages, which is a huge security risk.

panpawn · 2016-07-27T02:07:24Z

commands.js

 	},
 	unlogtexthelp: ["/unlogtext [username] - Removes a locked or banned user's messages from chat and clears them from the room's log. Requires: % (global only), @ * # & ~"],
+


there's trailing whitespace here

team1257Simon · 2016-07-27T02:40:26Z

I added a modlog thing...what users should have access to it then?
Sorry about all the commits, I'm new to these coding standards...

panpawn · 2016-07-27T02:43:57Z

I would say leaders and administrators probably

panpawn · 2016-07-27T02:48:36Z

Also, you can probably squash these commits

team1257Simon · 2016-07-27T03:07:42Z

Squashed

kotarou3 · 2016-07-27T06:58:11Z

commands.js

+		this.splitTarget(target);
+		let targetUser = this.targetUser;
+		let name = this.targetUserName;
+		if (!user.can("rangeban")) {


Do not overload permissions. Add a new separate one

I based the permissions checking and other setup checks on the hidetext command, which uses user.can("roomban"). If I need to make a new permission I can but I think the two actions are related closely enough that sharing the permission should suffice.

team1257Simon · 2016-07-27T15:32:00Z

I tested it and it worked...
As for the alts thing, with my understanding of how alts work it shouldn't matter which one I'm checking against.
As for the permissions, I didn't want to add a new permission because that would mean editing the config file to which I do not have access. The second check is to make sure the target user is banned, not to check permissions.
With the log index, I will change that, it's a remnant of when I tried a for ... in loop.

kotarou3 · 2016-07-27T17:01:00Z

Reply to each individual line comment to keep them organised
It matters in a case of user lookup count. You lookup the users once and cache that result, instead of doing it for every single log line
You can edit config-example.js
You have a || user.can('rangeban') at the end though

Zarel · 2016-07-27T20:45:36Z

The way I think I originally thought of this feature was as a side effect of roomban and lock. The text is still visible in the log files, but wouldn't appear to users joining the room in the future.

One of the consequences is that it would be harder for trolls/spammers to really know if their attacks successfully went through. Maybe an /evader command so it's only done for very obvious evading spammers.

team1257Simon · 2016-07-27T20:57:56Z

I'm actually fairly certain it won't delete the text from the log files, just the log that future users see. So basically, exactly your idea.

kotarou3 · 2016-07-28T05:07:37Z

Might want to double check how and when the logs are written (I don't know either)

Zarel · 2016-07-28T08:40:55Z

Oh, I know your implementation doesn't.

team1257Simon · 2016-07-28T14:18:28Z

@kotarou3 I checked, it logs to text every time a message goes through.
@Zarel if you want me to not have this be its own command (aka integrated into ban and lock) let me know, I will rename the PR

kotarou3 · 2016-07-28T15:18:51Z

commands.js

+			let message = room.log[i];
+			let split = message.split("|");
+			if (Users.get(split[3]) === this.targetUser || Users.get(split[3]).getAltUsers().indexOf(this.targetUser) >= 0) {
+				room.log.splice(i, 1);


You still end up skipping a log entry for each one you remove. Think carefully how room.log changes in respect to i when you splice(i, 1) it, and what happens in the next loop iteration

Oh, yeah i see what you're talking about. I'll fix that

kotarou3 · 2016-07-29T08:34:32Z

You still haven't properly addressed my other three comments

ascriptmaster · 2016-07-29T10:05:53Z

commands.js

+		if (!targetUser) return this.errorReply("User '" + name + "' not found.");
+		if (!(targetUser.locked || (room.bannedUsers[toId(name)] && room.bannedIps[targetUser.latestIp]) || user.can('rangeban'))) return this.errorReply("User '" + name + "' is not banned from this room or locked.");
+		let i = 0;
+		while(i < room.log.length) {


Travis is complaining about the missing space between while and the paren

Zarel · 2016-07-30T19:40:41Z

tbh my main issue is that I don't know exactly how this should be implemented, and there doesn't seem to be much consensus, either.

team1257Simon · 2016-08-02T13:10:56Z

Sorry for not responding, I've been away. I'll get back to this soon...

This is in tandem with smogon/pokemon-showdown#2645, and makes regular users unable to unhide text from banned users. Staff (moderator and up) retain this ability.

The unlogtext command clears a banned user's messages from the chat logs, which is useful if they leaked something sensitive/private. This was partially suggested in the issues file under "Fixes to text hiding."

kotarou3 · 2016-08-03T08:50:18Z

commands.js

+		let targetUser = this.targetUser;
+		let name = this.targetUserName;
+		let userid = targetUser.getLastId();
+		if (!user.can("rangeban")) {


Why not !this.can("rangeban")?

panpawn · 2017-07-12T13:40:48Z

This PR seems to be abandoned, and I think I know how I would go about this if it'd be okay if I were to take over:

Command name is /evader [user]
Removes user's text in the room and all of their previous names in room.log
Sends |unlink|perma|userid for the user's name and each of the user's previous names to the room

Also, what permission should this actually bet set to? I know I had said driver was probably a bad idea, but maybe just handle it like hidetext and allow drivers to if the user has been locked or roombanned.

Thoughts on this proposal?

Zarel · 2017-07-12T15:22:50Z

This is blocked by a database refactor; I'd suggest waiting until then.

panpawn · 2017-07-12T15:39:36Z

Okay then

Zarel · 2017-12-24T03:56:53Z

I'm just going to close this. I appreciate the effort here, but what I was looking for in Ideas for New Developers was an unlogging function to supplement existing |unlink|hide| use-cases, not an unlogging command.

panpawn reviewed Jul 27, 2016
View reviewed changes

team1257Simon force-pushed the master branch from 019f97b to 5c84577 Compare July 27, 2016 03:07

kotarou3 reviewed Jul 27, 2016
View reviewed changes

team1257Simon force-pushed the master branch from be1a11f to 13f5284 Compare July 28, 2016 14:23

kotarou3 reviewed Jul 28, 2016
View reviewed changes

team1257Simon force-pushed the master branch from 2ea092b to d26a279 Compare July 29, 2016 01:14

ascriptmaster reviewed Jul 29, 2016
View reviewed changes

team1257Simon mentioned this pull request Aug 2, 2016

Chat: make hidden message reveal staff-only smogon/pokemon-showdown-client#750

Closed

team1257Simon force-pushed the master branch from e11c2ca to 3148d26 Compare August 3, 2016 00:47

Add unlogtext command

5f1bdb3

The unlogtext command clears a banned user's messages from the chat logs, which is useful if they leaked something sensitive/private. This was partially suggested in the issues file under "Fixes to text hiding."

team1257Simon force-pushed the master branch from 3148d26 to 5f1bdb3 Compare August 3, 2016 01:02

kotarou3 reviewed Aug 3, 2016
View reviewed changes

Zarel mentioned this pull request Sep 21, 2016

Hide text when users join a room #2768

Closed

Slayer95 force-pushed the master branch from 1aabf2d to f02b22e Compare August 7, 2017 14:36

Zarel closed this Dec 24, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unlogtext command #2645

Add unlogtext command #2645

team1257Simon commented Jul 26, 2016 •

edited

Loading

panpawn Jul 27, 2016

panpawn commented Jul 27, 2016

panpawn Jul 27, 2016 •

edited

Loading

panpawn commented Jul 27, 2016

panpawn Jul 27, 2016

team1257Simon commented Jul 27, 2016 •

edited

Loading

panpawn commented Jul 27, 2016

panpawn commented Jul 27, 2016

team1257Simon commented Jul 27, 2016

kotarou3 Jul 27, 2016

team1257Simon Aug 2, 2016

team1257Simon commented Jul 27, 2016

kotarou3 commented Jul 27, 2016

Zarel commented Jul 27, 2016

team1257Simon commented Jul 27, 2016

kotarou3 commented Jul 28, 2016 •

edited

Loading

Zarel commented Jul 28, 2016

team1257Simon commented Jul 28, 2016

kotarou3 Jul 28, 2016 •

edited

Loading

team1257Simon Jul 29, 2016

kotarou3 commented Jul 29, 2016

ascriptmaster Jul 29, 2016

Zarel commented Jul 30, 2016

team1257Simon commented Aug 2, 2016

kotarou3 Aug 3, 2016

panpawn commented Jul 12, 2017

Zarel commented Jul 12, 2017

panpawn commented Jul 12, 2017

Zarel commented Dec 24, 2017

		},
		unlogtexthelp: ["/unlogtext [username] - Removes a locked or banned user's messages from chat and clears them from the room's log. Requires: % (global only), @ * # & ~"],

Add unlogtext command #2645

Add unlogtext command #2645

Conversation

team1257Simon commented Jul 26, 2016 • edited Loading

panpawn Jul 27, 2016

Choose a reason for hiding this comment

panpawn commented Jul 27, 2016

panpawn Jul 27, 2016 • edited Loading

Choose a reason for hiding this comment

panpawn commented Jul 27, 2016

panpawn Jul 27, 2016

Choose a reason for hiding this comment

team1257Simon commented Jul 27, 2016 • edited Loading

panpawn commented Jul 27, 2016

panpawn commented Jul 27, 2016

team1257Simon commented Jul 27, 2016

kotarou3 Jul 27, 2016

Choose a reason for hiding this comment

team1257Simon Aug 2, 2016

Choose a reason for hiding this comment

team1257Simon commented Jul 27, 2016

kotarou3 commented Jul 27, 2016

Zarel commented Jul 27, 2016

team1257Simon commented Jul 27, 2016

kotarou3 commented Jul 28, 2016 • edited Loading

Zarel commented Jul 28, 2016

team1257Simon commented Jul 28, 2016

kotarou3 Jul 28, 2016 • edited Loading

Choose a reason for hiding this comment

team1257Simon Jul 29, 2016

Choose a reason for hiding this comment

kotarou3 commented Jul 29, 2016

ascriptmaster Jul 29, 2016

Choose a reason for hiding this comment

Zarel commented Jul 30, 2016

team1257Simon commented Aug 2, 2016

kotarou3 Aug 3, 2016

Choose a reason for hiding this comment

panpawn commented Jul 12, 2017

Zarel commented Jul 12, 2017

panpawn commented Jul 12, 2017

Zarel commented Dec 24, 2017

team1257Simon commented Jul 26, 2016 •

edited

Loading

panpawn Jul 27, 2016 •

edited

Loading

team1257Simon commented Jul 27, 2016 •

edited

Loading

kotarou3 commented Jul 28, 2016 •

edited

Loading

kotarou3 Jul 28, 2016 •

edited

Loading