Calculate and display Elo change on server #7960
Conversation
| const ladderUpdatePromise = LoginServer.request('ladderupdate', { | ||
| p1: p1name, | ||
| p2: p2name, | ||
| score: p1score, | ||
| format: formatid, | ||
| }); |
There was a problem hiding this comment.
Could this just be moved down to where await ladderUpdatePromise is?
There was a problem hiding this comment.
This allows the loginserver's processing to happen concurrently with the server running and displaying the Elo changes. It's admittedly a small optimization, given that the Elo calc doesn't take much time; up to you if you want to change it.
| * Calculates Elo for quick display, matching the formula on loginserver | ||
| */ | ||
| // see lib/ntbb-ladder.lib.php in the pokemon-showdown-client repo for the login server implementation | ||
| // *intentionally* different from calculation in ladders-local, due to the high activity on the main server |
There was a problem hiding this comment.
Wait, in hindsight I think the only difference is because of ladder decay, which isn't implemented here.
Is the only difference here the 1300 vs the 1350? Maybe we should merge them.
There was a problem hiding this comment.
That's not the only difference; the numbers for scaling when elo < 1200 are also different.
ladders-local:
if (score < 0.5) {
K = 10 + (previousUserElo - 1000) * 40 / 200;
} else if (score > 0.5) {
K = 90 - (previousUserElo - 1000) * 40 / 200;
}
ladders-remote:
if (score < 0.5) {
K = 20 + (previousUserElo - 1000) * 30 / 100;
} else if (score > 0.5) {
K = 80 - (previousUserElo - 1000) * 30 / 100;
}
ladders-remote uses 20/80 instead of 10/90, and multiplies by 30 instead of 40.
There was a problem hiding this comment.
Interesting! We probably want to investigate the formulas more, later. But that's probably a job for a different PR.
Co-authored-by: Guangcong Luo <guangcongluo@gmail.com>
|
This is great! Thanks! |
This reverts commit b87dd71.
…ogon#8014) This reverts commit b87dd71.
Caused by smogon#8015 incorrectly copy/pasting only parts of smogon#7960. I also cleaned up the ladder fast-update code while I was working on this.
ladders-local.tsalready had the calculations for Elo change; I factored that out into a separate file that's called from bothladders-localandladders-remote.ladders-remotenow calculates Elo change immediately and displays it while waiting for the login server to return from updating the ladder.Fixes relevant bullet point on #2444.