Validator: Disallow duplicate moves #8191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnikaCodes
reviewed
Apr 10, 2021
Co-authored-by: Annika <annika0uwu@gmail.com>
AnnikaCodes
reviewed
Apr 10, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a user creates a Pokemon with multiple duplicate moves, the validator doesn't say anything is wrong and just removes the duplicated move from the user's moveset automatically. I've definitely made the mistake in the past where I quickly make a Pokemon's set, don't realize I really only have 3 moves, and don't figure it out until the battle. This also fixes an issue with automatic move changes (i.e. Iron Head -> Behemoth moves) where a user accidentally adds both Iron Head and the Behemoth move without realizing Iron Head becomes Behemoth Blade / Bash. This way, the mistake is exposed at the teambuilder level, so they don't think get confused about why a move is missing.
Sample:
Fixes https://github.com/smogon/pokemon-showdown/projects/3#card-51711810