Properly implement Chloroblast recoil #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have tests distinguishing this from Mind Blown, etc? If not I think those would be good to add. |
to be consistent with the struggle recoil block right below this block
|
Did anyone ever get around to testing how this works with Parental Bond? |
DaWoblefet
reviewed
Jul 11, 2023
DaWoblefet
reviewed
Jul 11, 2023
|
Would this be better implemented in the calcRecoilDamage function itself? |
I originally didn't do this because it would add an extra parameter to calcRecoilDamage, but now that I realize substitute has to do recoil damage itself it's probably better to implement it in calcRecoilDamage. |
I just tested it and the recoil was still 50%. |
|
Thanks Karthik! |
underscoreevelyn
pushed a commit
to underscoreevelyn/pokemon-showdown
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And by properly I mean the dumb way GF implemented this.
https://www.smogon.com/forums/threads/bug-reports-v4-read-original-post-before-posting.3663703/post-9699207
https://twitter.com/zakocky/status/1663886466525827072