Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support virtualedit #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yehuohan
Copy link

This PR allows hop to jump to anywhere you want with virtualedit used, even there is a blank cell like the picture showed below.
So any hop-regex/extension can supports virtualedit via only provide extra Cursor.off and Cursor.virt.
Currently hint_vertical and hint_lines can jump to blank cells when virutaledit = insert/block/all.

ve

@smoka7
Copy link
Owner

smoka7 commented Nov 22, 2023

Thanks for your contribiution. I'm not sure about adding this. It Doesn't seem a usefull feature and it adds more complexity to plugin.
I'm open to feedback from you or other users who might have insights to share.

@yehuohan
Copy link
Author

yehuohan commented Nov 22, 2023

Thank your reply.
This PR does introduce complexity on computing row and col with virtualedit enabled.
Actually I think only hint_vertical gets improved a lot for virtualedit users currently.
And hope there will be more extensions can make use of this feature. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants