Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust v1.67 #15

Merged
merged 14 commits into from
Feb 15, 2023
Merged

Update to Rust v1.67 #15

merged 14 commits into from
Feb 15, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 9, 2023

No description provided.

@tomaka tomaka enabled auto-merge (squash) February 9, 2023 09:35
@tomaka
Copy link
Contributor Author

tomaka commented Feb 9, 2023

I can't find anything in the Rust changelog regarding a change in behavior of VecDeque.
It is likely that the Noise code needs some non-insubstantial changes.

auto-merge was automatically disabled February 10, 2023 09:08

Merge queue setting changed

@tomaka
Copy link
Contributor Author

tomaka commented Feb 13, 2023

CI failure caused by actions/checkout#1169

@tomaka
Copy link
Contributor Author

tomaka commented Feb 14, 2023

I don't understand why only this PR is affected by this CI issue.

@tomaka
Copy link
Contributor Author

tomaka commented Feb 15, 2023

I don't understand why only this PR is affected by this CI issue.

I suppose that something has changed in the Rust Docker image between 1.65 and 1.67

@github-actions
Copy link

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────
     +116100 ┊ smoldot_light::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h3d3fc62adf079256
      +50620 ┊ smoldot::executor::host::ReadyToRun::run_once::h42c3df96ae951ef7
      -50338 ┊ smoldot::executor::host::ReadyToRun::run_once::h42471b52c5e6c06b
      +47476 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h5a405ce13d7acb11
      -45996 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hf88d34ec847a230f
      +35417 ┊ custom section '.debug_str'
      +29045 ┊ custom section '.debug_pubnames'
      -19070 ┊ <wasmparser_nostd::readers::core::operators::Operator as core::fmt::Debug>::fmt::h2fc7455473655f17
      +19070 ┊ <wasmparser_nostd::readers::core::operators::Operator as core::fmt::Debug>::fmt::h390d168f0f039f02
      -14578 ┊ <rand_chacha::chacha::ChaCha12Core as rand_core::block::BlockRngCore>::generate::h30aae5e8726d597c
      -14578 ┊ <rand_chacha::chacha::ChaCha20Core as rand_core::block::BlockRngCore>::generate::hae40d62a9c19e2c7
      +14577 ┊ <rand_chacha::chacha::ChaCha12Core as rand_core::block::BlockRngCore>::generate::hde92faef726cdbe5
      +14577 ┊ <rand_chacha::chacha::ChaCha20Core as rand_core::block::BlockRngCore>::generate::hd5816d3355e7f015
      +14067 ┊ <core::panic::unwind_safe::AssertUnwindSafe<F> as core::future::future::Future>::poll::h762d91d15db8dfaf
      +13152 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::hee2e5642b381d2c0
      +13105 ┊ smoldot_light::transactions_service::background_task::{{closure}}::hff054616699d5d93
      -13086 ┊ sha2::sha512::soft::sha512_digest_block_u64::h2bf5ee7840de5833
      -13086 ┊ sha2::sha512::soft::sha512_digest_block_u64::h6a4218d03752cc8e
      +13086 ┊ sha2::sha512::soft::sha512_digest_block_u64::h7b705c63123facae
      +13086 ┊ sha2::sha512::soft::sha512_digest_block_u64::hc36f759b53331634
     -120322 ┊ ... and 33177 more.
      +77261 ┊ Σ [33197 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 15, 2023
Merged via the queue into smol-dot:main with commit 24ed0d5 Feb 15, 2023
@tomaka tomaka deleted the rustup branch February 15, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant