Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network protocol names to use forkId instead of protocolId #155

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 10, 2023

Close #80

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +3619 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h889a89f01fdccdee
       -3399 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h285c1bb623062011
       +2406 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h1d59728b4f7ce5b5
       +2380 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h5a18713026c61d81
       -2380 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf92f0be4cf71a46b
       +1122 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::hdb717e1b53b3bc32
       +1008 ┊ hashbrown::raw::RawTable<T,A>::reserve_rehash::h2e5d4a79f7a54926
       -1008 ┊ hashbrown::raw::RawTable<T,A>::reserve_rehash::hf2c431ba6c99d9ef
        -716 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h2ea99cd22c8d122d
        +664 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb66d99b7b4477873
        -664 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc7084f7da2dc1c91
        +580 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h33f4768c1450c442
        -580 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8fe50f6d688520eb
        -412 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::start_services<smoldot_light_wasm::platform::Platform>::{{closure}}>>::h7799171dd47873a0
        +412 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::start_services<smoldot_light_wasm::platform::Platform>::{{closure}}>>::hc8108ea8e234b672
        +400 ┊ data[0]
        -393 ┊ <core::iter::adapters::chain::Chain<A,B> as core::iter::traits::iterator::Iterator>::next::h9f794ea4d688f5aa
        +393 ┊ <core::iter::adapters::chain::Chain<A,B> as core::iter::traits::iterator::Iterator>::next::hbd4a53a779b5de3d
        +381 ┊ core::ptr::drop_in_place<futures_util::future::future::remote_handle::Remote<core::future::from_generator::GenFuture<smoldot_light::Client<smoldot_light_wasm::platform::Platform>::add_chain<alloc::vec::into_iter::IntoIter<smoldot_light::ChainId>>::{{closure}}>>>::hced1b5a1df355a33
        -381 ┊ core::ptr::drop_in_place<futures_util::future::future::remote_handle::Remote<core::future::from_generator::GenFuture<smoldot_light::Client<smoldot_light_wasm::platform::Platform>::add_chain<alloc::vec::into_iter::IntoIter<smoldot_light::ChainId>>::{{closure}}>>>::he618ce61660d981b
        +652 ┊ ... and 255 more.
       +5883 ┊ Σ [275 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 13, 2023
Merged via the queue into smol-dot:main with commit 2c07227 Feb 13, 2023
@tomaka tomaka deleted the fix-80 branch February 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport protocol name changes and forkId
1 participant