Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark MutexGuard with #[clippy::has_significant_drop] #37

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Mark MutexGuard with #[clippy::has_significant_drop] #37

merged 2 commits into from
Feb 3, 2023

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Feb 2, 2023 •
edited

#[clippy::has_significant_drop] tells that a structure should be considered when evaluating some lints. Examples of such behavior are the existent clippy::significant_drop_in_scrutinee and the soon-to-be-finished rust-lang/rust-clippy#9399.

@c410-f3r
Mark MutexGuard with #[clippy::has_significant_drop]
21a1054 
`#[clippy::has_significant_drop]` tells that a structure should be considered when evaluating some lints. Examples of such behavior are the existent `clippy::significant_drop_in_scrutinee` and in the soon-to-be-finished rust-lang/rust-clippy#9399.
notgull
notgull requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but this should go on the other locking types as well, such as:

  • MutexGuardArc
  • SemaphoreGuard[Arc]
  • RwLock[Read/Write/UpgradableRead]Guard

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Feb 3, 2023

I like the idea, but this should go on the other locking types as well, such as:

* `MutexGuardArc`

* `SemaphoreGuard[Arc]`

* `RwLock[Read/Write/UpgradableRead]Guard`

Done

notgull
notgull approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@notgull notgull merged commit 39e0b6d into smol-rs:master Feb 3, 2023
@notgull notgull mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c410-f3r @notgull