Replace direct dependency on libc with rustix #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
warning: the borrowed expression implements the required traits
--> tests/std.rs:311:29
|
311 | cmd.env("PATH", &p);
| ^^ help: change this to: `p`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
```
notgull
approved these changes
Dec 30, 2022
src/lib.rs
Outdated
| syscall!(fcntl(fd, libc::F_SETFL, res & !libc::O_NONBLOCK)); | ||
|
|
||
| fn blocking_fd(fd: rustix::fd::BorrowedFd<'_>) -> io::Result<()> { | ||
| let flags = rustix::fs::fcntl_getfl(fd)?; |
There was a problem hiding this comment.
That behavior in the standard library seems to have been introduced in rust-lang/rust@efeb42b.
I wondered why it is linux-only, since FIONBIO is available on several other unix-like systems. After a little looking into it, in the standard library it seems mainly because it could not find docs on other operating systems (rust-lang/rust#39514 (comment)), and also this comment in libuv indicates that there are cases where it is not supported, at least on BSD. Also, this commit in mio indicates that it is not working as we expected on illumos.
So, for now, it seems to make sense to do it only on linux.
taiki-e
force-pushed
the
taiki-e/rustix
branch
from
763e435
to
c9b6b0b
Compare
notgull
approved these changes
Dec 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: smol-rs/async-io#76