Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for unbounded queues #13

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

gmorenz
Copy link
Contributor

@gmorenz gmorenz commented May 23, 2021

Does what it says on the tin.

I wrote this planning to propose changing the AtomicUsize in unbounded::Slot to an AtomicU8, turns out that doesn't really improve performance though so I won't be submitting that PR (image of benchmark attached, since the colors really help).

image

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I'd also add benches for the bounded queues as well.

@taiki-e taiki-e merged commit f8eca83 into smol-rs:master Aug 24, 2022
@taiki-e
Copy link
Collaborator

taiki-e commented Aug 24, 2022

Thanks!

(Opened #23 for bounded queue benches)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants