Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][#52]Remove the heap allocation from non-single queues #53

Merged
merged 3 commits into from
Nov 16, 2023
Merged

[FEATURE][#52]Remove the heap allocation from non-single queues #53

merged 3 commits into from
Nov 16, 2023

Conversation

mamaicode
Copy link
Contributor

#52
Draft

@mamaicode mamaicode marked this pull request as ready for review November 13, 2023 23:39
notgull
notgull requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, but I'd like a second opinion.

@smol-rs/admins Thoughts?

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@mamaicode mamaicode changed the title [DRAFT]Remove the heap allocation from non-single queues [FEATURE][#52]Remove the heap allocation from non-single queues Nov 14, 2023
@fogti fogti requested a review from notgull November 15, 2023 22:25
@fogti
Copy link
Member

fogti commented Nov 15, 2023

NOTE: use squash merging / better commit message.

@notgull notgull merged commit c0e1098 into smol-rs:master Nov 16, 2023
8 checks passed
This was referenced Nov 17, 2023
Closed
Merged
@notgull notgull mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti fogti approved these changes

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mamaicode @fogti @notgull