Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added char() implementations and tests #25

Merged
merged 2 commits into from
Jan 22, 2022
Merged

added char() implementations and tests #25

merged 2 commits into from
Jan 22, 2022

Conversation

BartMassey
Copy link
Contributor

This PR provides implementations of char for fastrand, together with some tests; closes #24.

@taiki-e
Copy link
Collaborator

taiki-e commented Jan 8, 2022

The title says that tests are added, but it seems that no tests are actually added.

@BartMassey
Copy link
Contributor Author

Forgot to add the tests. Thanks for catching this.

taiki-e
taiki-e approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 20bfa8d into smol-rs:master Jan 22, 2022
@taiki-e
Copy link
Collaborator

taiki-e commented Jan 22, 2022

Published in 1.7.0.

@taiki-e taiki-e mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needs char generator
2 participants
@BartMassey @taiki-e