Test patched async-io on more platforms #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
taiki-e/ci2
branch
2 times, most recently
from
b98bc7c
to
cf77093
Compare
taiki-e
force-pushed
the
taiki-e/ci2
branch
2 times, most recently
from
a6bc97a
to
2a2846d
Compare
notgull
approved these changes
Mar 26, 2023
|
As for vmactions, I was thinking of trying another action that may be faster.
We have tried something similar in tokio (for loom-related files). However, the effect of this may be smaller, because these targets may also be affected by changes in tests and doc examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #78
Blocked on smol-rs/async-io#110Also the increase in time taken to test with vmactions is annoying.