Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI #13

Merged
1 commit merged into from
Apr 25, 2020
Merged

Add Github Actions CI #13

1 commit merged into from
Apr 25, 2020

Conversation

llebout
Copy link
Contributor

@llebout llebout commented Apr 21, 2020

No description provided.

@llebout llebout force-pushed the leo-lb-add-ci branch 15 times, most recently from 5dd5bc8 to 10ba521 Compare April 21, 2020 12:47

jobs:
stable:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really should have macOs and Windows here too :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree :) Also BSD if it's available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stjepang BSD is not available unless you want to plug a custom runner, and if the actions runner works on BSD. But macOS is a bsd variant so that should at least cover most of failures.

@ghost
Copy link

ghost commented Apr 25, 2020

Can we rebase this on master branch to give CI a fresh run?

@llebout llebout force-pushed the leo-lb-add-ci branch 2 times, most recently from 17041c7 to 5d42395 Compare April 25, 2020 17:12
@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

Tried to add macOS and Windows but it might fail because the actions.rs Github Actions framework may not support these.

@dignifiedquire
Copy link
Contributor

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

@dignifiedquire Yes, it certainly does, I just tried to make use of: https://github.com/actions-rs

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

@dignifiedquire Looks like it works on macos and windows too, now it's just an issue with wepoll-sys not building somehow

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

@stjepang Already opened an issue for this here: https://gitlab.com/yorickpeterse/wepoll-sys/-/issues/1

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

Also we should watch this closely: actions-rs/meta#21

Caching is important, wasting compute resources is not fun. And well.. we can't say CI/CD as a concept isnt already a big source of energy waste..

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

And sorry for the repeated posts, but I have another thing to say:

It seems that build failure on windows canceled all the other build, is that OK?

@dignifiedquire
Copy link
Contributor

it woul be nice if the oses would run by themselves, especially as windows is a known failure atm

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

Also: servo/rust-cssparser#273 - for code coverage

@ghost
Copy link

ghost commented Apr 25, 2020

@Leo-LB To install LLVM on Windows: actions/runner-images#104 (comment)

@llebout
Copy link
Contributor Author

llebout commented Apr 25, 2020

@Leo-LB To install LLVM on Windows: actions/virtual-environments#104 (comment)

@stjepang Cool! I added that.

@ghost
Copy link

ghost commented Apr 25, 2020

Okay the remaining issue is easy to fix and unrelated - I'll do that separately from this PR since I'm updating lib.rs right now :)

Merging this, thank you for the PR! I'm very happy that we now have CI for the three major operating systems! <3

@ghost ghost merged commit e8f797b into master Apr 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the leo-lb-add-ci branch April 25, 2020 20:12
@llebout
Copy link
Contributor Author

llebout commented Apr 26, 2020

@stjepang I did not realize the repo was private here: servo/rust-cssparser#273 - stupid me.

@ghost
Copy link

ghost commented Apr 26, 2020

@Leo-LB It seems only code coverage is failing now but I don't understand why: https://github.com/stjepang/smol/runs/618593373

Do you have any ideas?

@llebout
Copy link
Contributor Author

llebout commented Apr 26, 2020

@stjepang yes look at the issue I opened against cssparser just above.

@llebout llebout mentioned this pull request Jul 12, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants