Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt+shift keychords not handled correctly #43

Closed
romgrk opened this issue Nov 1, 2020 · 10 comments
Closed

alt+shift keychords not handled correctly #43

romgrk opened this issue Nov 1, 2020 · 10 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@romgrk
Copy link

romgrk commented Nov 1, 2020

Mappings with <A-S-x> don't work.

@clason
Copy link
Collaborator

clason commented Nov 1, 2020

What is your keyboard layout? The equivalent to that in macOS (shift-option-x) seems to work.

@romgrk
Copy link
Author

romgrk commented Nov 1, 2020

Qwerty, en_US, on Linux.

@smolck smolck added bug Something isn't working help wanted Extra attention is needed labels Nov 8, 2020
@smolck
Copy link
Owner

smolck commented Feb 8, 2021

@romgrk Would you be able to try out latest master and see if this is still a problem? I'm not sure, but #124 might have resolved this issue.

@romgrk
Copy link
Author

romgrk commented Feb 11, 2021

On master at 0.28, alt and alt+shift keychords don't seem to work out of the box.

@smolck
Copy link
Owner

smolck commented May 5, 2021

@romgrk would you be able to check out this branch, run npm ci && npm run dev, and paste the output from the terminal when you type alt+shift+x, alt+x, etc.? That should provide a (hopefully useful) log of what uivonim's receiving when you press those key sequences (and thus what it's sending to neovim).

I would test it myself but unfortunately I don't really have a machine I can test this on atm.

@romgrk
Copy link
Author

romgrk commented May 6, 2021

Pressing any keyboard shortcut with starting with alt- doesn't produce any output in the console. But the rest works as expected. Alt keys might be being eaten by electron & the alt menu, I think I saw some issues about that back then, not sure what's the status on that.

@smolck
Copy link
Owner

smolck commented May 7, 2021

Oh, I see. electron/electron#28088 looks to be the issue? Maybe this could be hack-fixed within uivonim, but I’m not sure, need to look into it. Ideally that’ll just be fixed soon, and then no need to change anything in uivonim, but I’m not sure if it’s even being worked on atm unfortunately.

@romgrk
Copy link
Author

romgrk commented May 7, 2021

It's definitely possible to fix it though, VSCode's keybindings with alt- do work.

smolck added a commit that referenced this issue May 7, 2021
smolck added a commit that referenced this issue May 7, 2021
@smolck
Copy link
Owner

smolck commented May 7, 2021

So I tested this in an Ubuntu VM (with the mappings nnoremap <a-s-f> :echo 'hi'<cr> and nnoremap <a-f> :echo'hi'<cr>) and it seemed to fix the issue, mind giving it a shot @romgrk? ffaf90b

@romgrk
Copy link
Author

romgrk commented May 7, 2021

It works <:=]

@smolck smolck closed this as completed in ff6ca93 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants