dhcp: always send parameter_request_list. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
changed the title
|
@astro what are your thoughts on this? Is there some reason your implementation didn't send the reqlist on every packet? |
|
Added fix for a bug where the lease expiration is not cleared on reset. |
This was intentional at the time, but the more I've thought about it the more I agree it should be reset as well. Thanks for including the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.
Turns out the DHCP server wasn't sending the router/netmask/dns options due to us not requesting them on renews.
From reading the RFC it seems the server is allowed to not respond with parameters we don't ask. The solution is to ask for them.
Just asking for them on all DHCPREQUESTs seems to work, but I've seen all other DHCP clients request them in DHCPDISCOVERs too, so this is what I'm doing here.
Fixes a bug where the lease expiration is not cleared on reset.
If the DHCP server is gone and the lease expires, it would call reset(), which wouldn't clear the
self.lease_expirationfield. In next poll,lease_expiredcondition would match, immediatelly reset()ing again. This makes the client stuck in a reset loop.