Simplify socket handling #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
iface-sockets
branch
2 times, most recently
from
2759270
to
0ce00ed
Compare
|
bors r+ |
|
Build failed: |
The intent was to run custom code after the user is done modifying the socket, for example to update a (not yet existing) port->socket map in SocketSet. However this wouldn't work, since the SocketRef would have to borrow the SocketSet at the same time as the Socket to be able to notify the SocketSet. I believe such indexing can be achieved by setting a "dirty" bit *before* giving the socket to the user, then on poll() reindexing all dirty sockets. This could even be faster: if user gets a socket multiple times between polls, it'd be reindexed only once.
It is never used in practice, so it's not worth the complexity and the extra RAM usage.
Dirbaio
force-pushed
the
iface-sockets
branch
from
0ce00ed
to
21e3dad
Compare
|
needed some rebasing bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 26, 2021
571: socket: simplify, make SocketSet private. r=Dirbaio a=Dirbaio This completes the work started in #557. Since `Interface` now owns the sockets, `SocketSet` is now an implementation detail, so it is made private. Also `SocketMeta` is moved from each socket to the SocketSet. `SocketMeta` is arguably an `Interface` implementation detail as well, mainly used for neighbor discovery. it also reduces a bit of code duplication. Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages