More heapless #722
Merged
More heapless #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
force-pushed
the
heapless
branch
3 times, most recently
from
315bbea
to
895c1d5
Compare
Lookup is O(n) now. However, it previously did 32 (or 128 for ipv6!) map lookups. Since the route table typically doesn't have that many routes, the new code is likely faster even if it's O(n).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More heapless use, continues work started in #719
Use heapless for Routes and NeighborCache.
Routes reduces code size by 1.7kb. Makes sense since the new code is much simpler (no maps).
NeighborCache increases code size by 152 bytes. Not sure why, it should also be simpler....