New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooch.open does not open conversation widget in FF 59.0.2 (TypeError) #664

Closed
kschiu opened this Issue May 16, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@kschiu

kschiu commented May 16, 2018

I'm submitting a ...

  • bug report

What is the current behavior?

  • Smooch.open() does not properly open the conversation widget in Firefox 59.0.2
  • Conversation widget opens properly in Chrome Version 66.0.3359.139

Please provide the steps to reproduce and, if possible, a minimal demo of the problem

  • Invoke Smooch.open in Firefox 59.0.2

What is the expected behavior?

  • Smooch.open() opens the conversation widget in Firefox 59.0.2

Please tell us about your environment:

  • Delivery method: [ CDN ]
  • Version [Smooch.4.11.2]
  • Browser: [ Firefox 59.0.2 ]
  • OS: [ OS X 10.13.1 ]

Other information

Stacktrace:
smooch_ff_error

Error seems to be in frame.4.11.2 ?

Was able to get a little more information by catching all exceptions:
smoochtypeerror

Apparently in FF, when getComputedStyle() is called inside an iframe with display: none, null is returned: link here

@alavers

This comment has been minimized.

Member

alavers commented May 18, 2018

Thanks for the detailed report! The fix seems fairly straightforward.

@alavers alavers added the bug label May 18, 2018

@alavers

This comment has been minimized.

Member

alavers commented May 28, 2018

Fixed in 4.11.3

@alavers alavers closed this May 28, 2018

@kschiu

This comment has been minimized.

kschiu commented May 29, 2018

@alavers

It looks like we're still running into the issue in v4.11.3:
screen shot 2018-05-29 at 10 11 18 am

Is there any other information I can provide you with? Thanks!

@alavers

This comment has been minimized.

Member

alavers commented May 29, 2018

@kschiu yes looking closer now and it does seem the fix we shipped is helpful, but incomplete.

Can you share with me the context in which you're running v4.11.3? I wasn't actually able to reproduce this bug with Firefox 59.0.2, but if I had a reliable repro I'd stand a better chance at fixing it.

@alavers alavers reopened this May 29, 2018

@kschiu

This comment has been minimized.

kschiu commented May 29, 2018

@alavers Could you explain what you mean by the context? Do you mean what our code is like? Or our environment?

@alavers

This comment has been minimized.

Member

alavers commented May 29, 2018

@kschiu I'm asking about the page in which you're hosting the widget, since I'm unable to reproduce the issue myself.

In any case, I've implemented another fix that just went out with the 4.12.0 release. Could you re-test?

@kschiu

This comment has been minimized.

kschiu commented May 29, 2018

@alavers It looks good to me, the widget is now loading properly! Thank you for your help I really appreciate it!

@kschiu kschiu closed this May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment