Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmooksUtil: Exception created but not thrown #158

Closed
michihenninger opened this issue Jan 7, 2019 · 0 comments · Fixed by #320
Closed

SmooksUtil: Exception created but not thrown #158

michihenninger opened this issue Jan 7, 2019 · 0 comments · Fixed by #320
Assignees
@cjmamo
Labels
type: bug Something isn't working
Milestone
v2.0.0-M2

Comments

@michihenninger
Copy link

In class smooks-core/src/main/java/org/milyn/SmooksUtil.java there is an Exception created but not thrown on line 108:

} catch (IOException e) { new SmooksException("Failed to close stream...", e); }
@cjmamo cjmamo self-assigned this Mar 1, 2021
@cjmamo cjmamo added this to the v2.0.0-M2 milestone Mar 1, 2021
@cjmamo cjmamo added the type: bug Something isn't working label Mar 1, 2021
@cjmamo cjmamo linked a pull request Mar 1, 2021 that will close this issue
Breaking API changes to improve dependency injection #320
Merged
@cjmamo cjmamo closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjmamo cjmamo

Labels
type: bug Something isn't working
Milestone
v2.0.0-M2
Development

Successfully merging a pull request may close this issue.

Breaking API changes to improve dependency injection
2 participants
@cjmamo @michihenninger