Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MILYN-588 #28

Merged
merged 1 commit into from Apr 20, 2011
Merged

MILYN-588 #28

merged 1 commit into from Apr 20, 2011

Conversation

zubairov
Copy link
Member

Implemented validation of XML going from EDIParser with the XML Schemas generated inside the UN/EDIFACT mapping JARs.
Fixed a severe bug in EcoreGenerator which affect generated XML Schemas too.

@tfennelly
Copy link
Member

Hey Renat... would you mind rebasing and squashing all of these commits into a single commit and make sure all is OK.

@zubairov
Copy link
Member Author

yup. BTW what r u doing here in your vacation?

…fact artifacts, fixed major issue in UN/EDIFACT XML Schemas
@zubairov
Copy link
Member Author

Done. Rebased and squashed.

@tfennelly tfennelly merged commit 49a8d4f into smooks:master Apr 20, 2011
@tfennelly
Copy link
Member

hehehe.... we're at home so never too far from my laptop ;)

@tfennelly
Copy link
Member

Hey Renat/..... is there a JIRA associated with this?

@tfennelly
Copy link
Member

Have one or 2 suggestions...

  1. The EDI utils validation stuff looks great Renat. I wonder if we could make it a more general utility i.e. not just for EDI? We could pull it up into a more top level module under smooks e.g. "smooks/schemaval". I see we have one bit that would need to be pulled out, which is the auto adding of the edifact envelope namespace. That would be easy enough to extract I think.
  2. EDIParser: Re the stripping of empty fields... shouldn't we be doing the same for components? See mapComponent().
  3. EDIParser: Re the stripping of empty fields... how about making this configurable for Backward Compatibility reasons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants