Made socket listener optional (required when using dev-middleware only) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ract their path once during init
gregberge
requested changes
Mar 21, 2019
src/index.js
Outdated
| class ErrorOverlayPlugin { | ||
| apply(compiler) { | ||
| const className = this.constructor.name | ||
|
|
||
| if (compiler.options.mode !== 'development') return | ||
|
|
||
| const enableDevServer = !!compiler.options.devServer |
There was a problem hiding this comment.
enableDevServer is an action, please rename it to devServerEnabled.
|
Thanks! |
|
You are welcome! |
|
Is this a breaking change? It doesn't really look like one. |
|
No it is not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the socked client optional which was used before for some more detailed error reporting. Unfortunately, this socket is only available when using
webpack-dev-serverand notwebpack-dev-middleware.The PR splits the entries for a basic integration and the socket listener into two. It then only adds the socket listener entry whenever there is a
devServerconfig entry in Webpack.The PR restores the previous behavior of v0.16.x for non-
dev-serverusers.