Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes --watch mode server start&restarts #299

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Fixes --watch mode server start&restarts #299

merged 1 commit into from
Dec 18, 2019

Conversation

lakesare
Copy link
Contributor

@lakesare lakesare commented Dec 3, 2019 •
edited

Summary

Fixes #229, fixes #181.

Test plan

The jest /tests/endtoend/** --watch command will:

  1. Start up the servers I defined in jest-puppeteer.config.js.
  2. And, if I save some test file, - it will successfully rerun the tests (while defined servers are running) - fix: start/stop devServer on watch mode (fixes #229) #298 PR fails this test for me.

@lakesare lakesare mentioned this pull request Dec 4, 2019
Closed
@nazimamin
Copy link

@gregberge it'd be great if we can get this merged and released.

@gregberge gregberge merged commit d49a6a1 into argos-ci:master Dec 18, 2019
@gregberge
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FezVrasta FezVrasta FezVrasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In watch mode server doesn't start Jest --watch fails to reload
4 participants
@lakesare @nazimamin @gregberge @FezVrasta