Envjsrb #21
Closed
Envjsrb #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… textarea (as per http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-24874179). Not supporting the value property correctly breaks the jquery val() function (as that will ask a node for its value) which in turn breaks the jquery serialize() function.
…xpectations they were expecting.
|
Commited. Thanks! |
|
That's great, cheers Steven. Is there any chance you could release a new version of the gem? Or, could you include the compiled static.js and a gemspec in the repository so that forks of the project can use gembundler to point to custom versions of the library? Cheers, Chris. |
|
Yeah, today or tomorrow I expect. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value property of a textarea should return the content of that textarea (as per http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-24874179). You can currently get the content of the textarea from the innerText property but that's no good for jquery. The jquery val(), and in turn serialize(), function expects to be able to use the value property, as per the DOM specification.
These commits add tests and a textarea specific value property that's currently just an alias for innerText.