Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to QWebEngine #21

Closed
wants to merge 3 commits into from
Closed

Port to QWebEngine #21

wants to merge 3 commits into from

Conversation

qarkai
Copy link

@qarkai qarkai commented Nov 10, 2022

Related to #7.
Ported partially. Only context menu works. No cookies, no cache.

@antonio-rojas
Copy link

Hi, Arch Linux qtwebkit maintainer here. Are you planning to follow up on this in the near future? Otherwise we'd have to drop smtube from the repos soon.

@qarkai
Copy link
Author

qarkai commented Nov 16, 2022

@antonio-rojas
Short answer: no.
Long answer: I tried to build with Qt WebEngine and decided to share required changes with community. I'm not sure I able to port all features. I might add more patches later but can't say when.
Let's close this PR if it's confusing.

@barracuda156
Copy link

If anyone proceeds with this, please retain compat code for Qt4 systems, it is very much needed.

@smplayer-dev
Copy link
Owner

I'm not going to port smtube to QWebEngine. There wont' be any more releases of smtube.
I think it would better to write a widget for smplayer that uses the Youtube API to get the results.

@barracuda156
Copy link

I'm not going to port smtube to QWebEngine. There wont' be any more releases of smtube. I think it would better to write a widget for smplayer that uses the Youtube API to get the results.

In principle, of course, a module in some working player is more convenient than a separate app which still has to call an external player.

@qarkai qarkai closed this Jan 18, 2024
@barracuda156
Copy link

@qarkai Just in case, if you will happen to be interested to complete this, please consider submitting a PR to Macports. (But we need to retain fallback code to support Qt4.)

@qarkai
Copy link
Author

qarkai commented Jan 18, 2024

@barracuda156 I'm not interested anymore, sorry. Feel free to use any part of this PR that you find useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants