Miscellaneous fixes #1129
Merged
Miscellaneous fixes #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a result of the `$unvisitedSectors` array being empty, which
caused the SQL query to use a `AND sector_id NOT IN ()` clause. This
clause is now omitted if the array is empty.
I suspect that this worked in the past due to the escaping mechanism
in `escapeArray`, likely resulting in `AND sector_id NOT IN ('')`
(see the `$autoQuotes` option, which was removed in 3b996d9).
Use `IFloor` instead of `floor` to compute the amount of each hardware to buy so that we have an int instead of a float. Fixes: > TypeError: doUNO(): Argument #2 ($amount) must be of type int, float given
The logic for deciding to buy hardware has been significantly simplified.
In the `displayGrouped` and `displayMessage` functions, we now return the constructed message (an array) instead of passing in the message box by reference and appending to it inside the functions. This fixes an issue with scout messages where the "GroupedMessages" element did not yet exist, but we were passing it by reference to the `displayMessage` function as if it were an array. This caused the following error: > TypeError: displayMessage(): Argument #1 ($messageBox) must be of type array, null given
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
=========================================
Coverage 13.82% 13.82%
Complexity 3955 3955
=========================================
Files 85 85
Lines 11692 11692
=========================================
Hits 1616 1616
Misses 10076 10076 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified by errors collected after the engine update for Game 142.