Fix for #20 - color transition now returns correct state #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding two new methods: * setFadeToColor: sets the end color that the fade will fade to. This is so that the correct state can be sent to MQTT (this is the end state after the fade has completed). * setFadeColor: Used to fade the color without updating the internal m_color variables that represent the color the fading will change to. This method also includes a similar fix to that in smrtnt#21, so if the color is set with a transition from the off state, it will set the internal state to ON.
alexschwantes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #20. Setting a transition in the color command now returns the correct end state to MQTT.