Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix typo in default database.yml #77

Merged
merged 3 commits into from Oct 29, 2023
Merged

Conversation

ItsNiceCraft
Copy link
Contributor

@ItsNiceCraft ItsNiceCraft commented Oct 25, 2023

The entry "database_name" is called "database_same" in the default database.yml file generated when the plugin first launches. This PR fixes this.

Also sets the example database name to "Leaf" because "Database" is not viable as a name.

Closes #78

Copy link
Owner

@smuddgge smuddgge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this must also be changed in the code, but I could be wrong. Will have a look when I'm next free 👍

@smuddgge
Copy link
Owner

#78 Link to issue

@ItsNiceCraft
Copy link
Contributor Author

Didn't do an in-depth look into it, just searched for the string "database_same" and the example database.yml file was the only match.

@smuddgge
Copy link
Owner

Just double checked looks good

Copy link
Owner

@smuddgge smuddgge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smuddgge smuddgge merged commit b639a47 into smuddgge:main Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

database.yml Spelling Error
2 participants