Engine of awesomeness #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engine subscriptions introduced
Argument validation added for Clock subscribe
…to dependency when archiving/removal required
GameTime values & equality introduced SchedulerOptions for Initial Game Time Multiplier introduced
…ad and thread blocking
Configurably spin waiting fuzzy matched times
Argument validation tested on scheduler
…psing subscriptions
… fall out of scope!
Closed
|
Latest commits fix #9 |
|
CI correctly identified an issue (not found locally due to racing condition) |
Open
|
Going to collapse this to dev. The code looks pretty good and we can raise technical debt issues as bugs whilst it's in dev? Idea being @herecydev and I will be working on #1 and #2 concurrently, and we'd rather base those branches on the merged dev than a PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awful lot to go through here.
The scheduler is unsafe, but is not completely untested.
Integration Tests are disabled within the branch, use optional compilation symbols to enable.
I welcome any feed back!
Fixes #6