kcapi-kdf: Move code to fix #83
Conversation
|
How about moving also the whole # ifdef __HAVE_BUILTIN_BSWAP32__
# define be_bswap32(x) (uint32_t)__builtin_bswap32((uint32_t)(x))
# else
# define be_bswap32(x) _bswap32(x)
# endifActually, you should then also move the inline functions straight under the |
kraj
force-pushed
the
master
branch
2 times, most recently
from
a028eaf
to
00c1654
Compare
|
@WOnder93 please check the latest version of patch, it should address your comments. |
kraj
force-pushed
the
master
branch
2 times, most recently
from
36637cd
to
7b5dd67
Compare
|
Looks good now! (One minor nit: I would leave the first letter of the error message uppercase, but it's not a big deal :) |
Fixes clang build unused function '_bswap32' [-Werror,-Wunused-function] Signed-off-by: Khem Raj <raj.khem@gmail.com>
clang pretends to be gcc 4.2.1 so GCC_VERSION macro will decide that __builtin_bswap32 is not supported on clang, whereas in reality it might so its better to add a check for enquiring clang if it supports __builtin_bswap32 or not Signed-off-by: Khem Raj <raj.khem@gmail.com>
makes sense, done, please re-review |
|
Thank you very much. Applied. (sorry for the delay, but the LRNG development took my time) |
Fixes clang build
unused function '_bswap32' [-Werror,-Wunused-function]
Signed-off-by: Khem Raj raj.khem@gmail.com