Fix taboo topic checking without session username

Merged njouanin#151
smurfix · Apr 14, 2019 · 8dcc234 · 8dcc234
1 parent 4bdff73
commit 8dcc234
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/hbmqtt/plugins/topic_checking.py b/hbmqtt/plugins/topic_checking.py
@@ -26,12 +26,11 @@ async def topic_filtering(self, *args, **kwargs):
         if filter_result:
             session = kwargs.get('session', None)
             topic = kwargs.get('topic', None)
-            if topic:
-                if session.username != 'admin' and topic in self._taboo:
-                    return False
+            if session.username and session.username == 'admin':
                 return True
-            else:
+            if topic and topic in self._taboo:
                 return False
+            return True
         return filter_result