Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using h3 as tag for title #13

Closed
rcharre opened this issue Sep 11, 2020 · 2 comments
Closed

Using h3 as tag for title #13

rcharre opened this issue Sep 11, 2020 · 2 comments
Labels
enhancement New feature or request
Projects
flash-message-vue

Comments

@rcharre
Copy link

rcharre commented Sep 11, 2020

Hello,

You are currently using a h3 tag to apply style on a text, this is against some a11y rules, you should probably replace it by a custom class styled text.

Regards,
@smwbtech
Copy link
Owner

Hi, @rcharre

Thanks for recommendations! Yep, I guess it would be better solution, when I started this component I didn't think about accessibility. I finally got time for my open source projects, I guess in two weeks I'll release a new patch and include this changes.

@smwbtech smwbtech added the enhancement New feature or request label Sep 12, 2020
@smwbtech smwbtech added this to To do in flash-message-vue Sep 12, 2020
smwbtech added a commit that referenced this issue Sep 17, 2020
@smwbtech
Changed tag for message title
715c362 
* Changed: h3 tag to p tag for title
* Added: ._vue-flash-msg-body__title class for message title
* Added: ._vue-flash-msg-body__text class for message text

According to #13
@smwbtech
Copy link
Owner

Fixed in 0.6.5 patch:
baf5bb7

@smwbtech smwbtech moved this from To do to Done in flash-message-vue Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
flash-message-vue
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smwbtech @rcharre