Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing peer dependency #207

Closed
wants to merge 1 commit into from
Closed

Fix missing peer dependency #207

wants to merge 1 commit into from

Conversation

dpilafian
Copy link

Issue #206

npm WARN gulp-jshint@2.1.0 requires a peer of jshint@2.x but none is installed.
You must install peer dependencies yourself.

npm WARN gulp-jshint@2.1.0 requires a peer of jshint@2.x but none is installed.
You must install peer dependencies yourself.
@pioug
Copy link
Collaborator

pioug commented May 29, 2019

Thanks @dpilafian! I'll remove the gulp tasks/plugins altogether instead. A couple of npm scripts would be enough 😛

#208

@pioug pioug closed this May 29, 2019
@dpilafian
Copy link
Author

dpilafian commented May 29, 2019

Yep, and I had already removed gulpfile.js on my local fork. However, it's good practice to clean up bugs before making improvements, so I submitted the bug fix first. I also have a bunch of fixes ready to go from errors found by jshint.

The same thing happened with my pull request that you rejected to fix the internalBinding error. I did that fix so I could do the upgrade to gulp 4. Issue #203

Do you not want people to contribute to your project?

@pioug
Copy link
Collaborator

pioug commented May 29, 2019

I am sorry for the lack of communication, I just want to take shortcuts since I don't want to spend time to follow migration paths.

I am really sorry for the time you have spent on it. However, I think it's also good practice to discuss issues first to decide whether they are worth solving.

@dpilafian
Copy link
Author

Migration paths? Huh? You click merge, it's done.

Good luck with your project. Bye.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants