Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Fill Cavities #3

Closed
RebelKeithy opened this issue Jun 5, 2020 · 7 comments
Closed

[FEATURE REQUEST] Fill Cavities #3

RebelKeithy opened this issue Jun 5, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@RebelKeithy
Copy link

RebelKeithy commented Jun 5, 2020

Is your feature request related to a problem? Please describe.
When hollowing a model in the slicer, sometimes there are small cavities that can't use drain holes.

Describe the solution you'd like
The program should be able to go through layer by layer and find cavities that don't have holes, and fill these cavities with white pixels.

Describe alternatives you've considered
No easy alternatives to this except leave the cavities filled with liquid resin

Additional context
I realize this isn't a simple feature request. My initial thoughts on how to do this would be:
1: Flag all black pixels on the border of the 3d space
2: For each black pixel that is not flagged:
3: > If it is adjacent to a flagged pixel, flag it
4: If a pixel was flagged in the last step, go to 2
5: All black pixels that are not flagged are set to white

@RebelKeithy RebelKeithy added the enhancement New feature or request label Jun 5, 2020
@sn4k3
Copy link
Owner

sn4k3 commented Jun 5, 2020

I don't think i full understand the problem, can you send a image sample? Note that i'm not used to resin printing, i never own one and real problems on resin printing are all new to me.
The solution you indicate can be solved using the mutators already in app

@RebelKeithy
Copy link
Author

Here's an example of the problem. I've hollowed this model with chitubox and have a cavity here that doesn't have a drain hole. When printed it will be filled with liquid resin, so if anything happens to crack the print there could be hazardous resin leaking out.
Capture_cav
Capture_cav_2

@sn4k3
Copy link
Owner

sn4k3 commented Jun 5, 2020

As i understand every drain hole must be done by user & inspection, chitubox hallow doesn't generate them right? On that case you don't want do a drain hole on model but just fill that area correct?
I can start thinking over that, a hallow area detector...

@RebelKeithy
Copy link
Author

Yes, that area is so small (about 1.5mm wide) there's no place to make a drain hole.

@sn4k3
Copy link
Owner

sn4k3 commented Jun 5, 2020

I will take that into consideration and good feature to have.
Today i will release a new version which fix cbt and cbddlp file save, if you were saving files for that formats with AA > than 1 please discard them and redo with new version

@sn4k3
Copy link
Owner

sn4k3 commented Jun 5, 2020

Also consider using PrusaSlicer instead o chitubox, way better...

sn4k3 added a commit that referenced this issue Jun 19, 2020
* (Add) Resin Trap issue validator and repairer - Experimental Feature (#3)
* (Add) Layer Repair tool can now fix Resin Traps when selected
* (Add) "Remove" issues button fix selected Resin traps, the operation now run under a thread and in a parallel way, preventing the GUI from freeze
* (Change) "Repair Layers" button renamed to "Repair Layers and Issues"
* (Fix) When do a "repair layers" before open the Issue tab, when open next it will recompute issues without the need
@sn4k3
Copy link
Owner

sn4k3 commented Jun 19, 2020

https://github.com/sn4k3/UVtools/releases/tag/v0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants