Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Erase drawing edits #63

Closed
tofof opened this issue Sep 18, 2020 · 7 comments
Closed

[FEATURE REQUEST] Erase drawing edits #63

tofof opened this issue Sep 18, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@tofof
Copy link

tofof commented Sep 18, 2020

Is your feature request related to a problem? Please describe.
I click to draw with e.g. an 8 pixel brush and misjudge exactly where I need to click.
If I notice immediately I can fix it by removing edits from the top of the list until it's fixed -- however, this wasn't intuitive.
But if I notice after doing several more edits it's very difficult to determine which ones would fix it.

Describe the solution you'd like
Erase edit mode - draw with cursor to return green or red pixels to the original unedited state

Describe alternatives you've considered
Cursor that shows bounds of area you're going to draw in would also help:
cursor

Additional context
The text for brush size should probably be "diameter ... px" instead of "area ... px2", since setting it to 5 gives you a 5x5 cursor of 25 px2 area.

@tofof tofof added the enhancement New feature or request label Sep 18, 2020
@sn4k3
Copy link
Owner

sn4k3 commented Sep 18, 2020

You mean after release button pixels are shifted right?

About the labels i didnt understand what's wrong, if you set 5px2 that's equal to 25px diameter so it's correct labeled.
Or do you mean turn into pixel diameter instead to be more intuitive? If so theres a big problem with that, a square is given by x * y, lets supose user enter 3px, that will turn into 1.5 * 1.5, and theres no fraction of pixels and that will be cast to 2*2 misplacing and invalidate user input. So diameter must be even number for both square and circle. That's why i give area instead

@tofof
Copy link
Author

tofof commented Sep 18, 2020

You mean after release button pixels are shifted right?

No. On one of the 0.7 versions that would happen, but that's not what I'm talking about (and already seems to be fixed.)
I just mean my own error - if click in the wrong place, it would be nicer to fix that by being able to click and drag with a modifier key to erase the green/red pixels, instead of trying to find the right edits in the list to choose 'remove' on.
The better cursor would eliminate some of my error by letting me see better what will be painted in, but doesn't help if I just click badly.

Regarding the label:
Your example is correct - asking user for area just creates problems.
We both agree the user should input diameter.
But right now, the text says "area"/"px2".
It should say "diameter"/"px" since that's what you actually want user to input.

if you set 5px2 that's equal to 25px diameter so it's correct labeled.

That sentence is wrong, which is the problem. You have the words swapped.
5 = diameter.
25 = area.

@tofof
Copy link
Author

tofof commented Sep 18, 2020

(I thought the confusion was just getting area and diameter mixed up since English is not your first language, but then I had a second thought).
Maybe part of the confusion is the "px2" part?

5 meters * 5 meters = 25 square meters = 25 m2
I interpreted px2 like this.

But maybe you were trying to indicate something like
[ 5 m ]2 = 25 square meters

It's extra weird because pixels are actually already a 2-dimensional unit, unlike meters, so px2 is a strange thing to write anyway.

In any case, the text field should definitely say "diameter" (or "length" if you want to be picky for rectangles), since that's what you want user to give.

@sn4k3
Copy link
Owner

sn4k3 commented Sep 18, 2020

No. On one of the 0.7 versions that would happen, but that's not what I'm talking about (and already seems to be fixed.) I just mean my own error - if click in the wrong place, it would be nicer to fix that by being able to click and drag with a modifier key to erase the green/red pixels, instead of trying to find the right edits in the list to choose 'remove' on. The better cursor would eliminate some of my error by letting me see better what will be painted in, but doesn't help if I just click badly.

I see now, like a rubber? To erase/undo your drawings and keep the original behind?

Yes you are right about the labels it will fix that

@tofof
Copy link
Author

tofof commented Sep 18, 2020

I see now, like a rubber? To erase/undo your drawings and keep the original behind?

Exactly.

@sn4k3
Copy link
Owner

sn4k3 commented Sep 18, 2020

Ok, about the cursor preview, it will be implemented on the next generation of UVtools (v1), right now no viable option without impacting performance and no alpha to do it right

sn4k3 added a commit that referenced this issue Sep 19, 2020
* (Add) Pixel Editor: Erase drawing edits while hold Control (#63)
* (Add) Pixel Editor: When using diameters larger than 1px and when possible the cursor will show the associated drawing preview (#63)
* (Fix) Pixel Editor: Area px<sup>2</sup> to Diameter px (#63)
@sn4k3
Copy link
Owner

sn4k3 commented Sep 19, 2020

implemented

@sn4k3 sn4k3 closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants