Extract suction cup drilling to common function #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the repair operation as well as the deletion of an issue will now leverage common code for executing a repair. Repair operation will repair all suction cups, and deleting a specific suction cup will only repair that one.
sn4k3
added a commit
that referenced
this pull request
Sep 21, 2021
- Issues:
- **Suction cups:**
- Add a auto repair feature for this issues by drill a vertical vent hole (#296)
- Add a manual repair feature for this issues by drill a vertical vent hole when click on remove (#301)
- (Add) Allow to group issues by type and/or layer on display list (Configurable)
- (Add) Linked issues (Resin traps and suction traps) are now grouped into a single main issue (#300)
- (Add) Tracker bar: Colorize the issue tracker map with it own colors (Configurable)
- (Improvement) Order issues by area in descending order
- (Improvement) Always bring the selected issue into UI view on the list
- (Fix) When manually removing a issue from the list, it will no longer reselect other and make the user loss track of the remove issue view
- (Fix) Allow to ignore all issue type
- Tool - Repair layers and issues:
- (Improvement) Allow to have profiles in the dialog
- (Improvement) Ignored issues are not repaired
- (Fix) Material ml calculation was calculating a bad value for PhotonWorkshop files
- (Fix) Settings were not being saved on systems that lacks special folder information, ie Rosetta. Now it will use up to 4 possible special folders as fallback if the prior doesn't exists (#299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the repair operation as well as the deletion of an issue will now leverage common code for executing a repair. Repair operation will repair all suction cups, and deleting a specific suction cup will only repair that one.