Skip to content

Commit

Permalink
connectx4: Comment on ommitted SET_DRIVER_VERSION
Browse files Browse the repository at this point in the history
  • Loading branch information
lukego committed Jun 14, 2016
1 parent 4575dc7 commit 8c0be9d
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/apps/mellanox/connectx4.lua
Expand Up @@ -49,6 +49,18 @@
-- this driver without signatures. It seems potentially futile
-- to calculate and include command signatures if they are not
-- actually being verified by the device.
--
-- DRIVER VERSION: This driver does /not/ identify itself via the
-- command SET_DRIVER_VERSION. That interation could lead to
-- hazards in the spirit of HTTP User-Agent where the adapter
-- firmware would behave differently depending on how the
-- driver identifies itself.
--
-- This decision could be revisited in the future when the
-- motivation for this mechanism is better understood. (The
-- card and firmware being used for initial development is not
-- asking the driver to identify itself anyway.)


module(...,package.seeall)

Expand Down

0 comments on commit 8c0be9d

Please sign in to comment.