core.app: add a post_link() app method #1188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing link() method is called for all add/remove actions per link. In some cases, it is convenient or even necessary to let an app perform actions after link configuration is completed but before the app is run. The method is only invoked when at least one link was changed (added or removed).
|
Looks about right but also needs support in |
|
Ok. Unfortunately, |
|
@wingo Could I possibly test/merge this as-is? Support in apps/config (which I believe is in flux?) could be added later on. I would add a note to https://github.com/snabbco/snabb/blob/master/src/apps/config/README.md explaining that Rationale: this seems already useful for downstream projects that don’t use apps/config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing link() method is called for all add/remove actions per
link. In some cases, it is convenient or even necessary to let an app
perform actions after link configuration is completed but before the
app is run. The method is only invoked when at least one link was
changed (added or removed).